Warning but no error if compile_standalone but no functions found
#956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgabry
commented
Apr 22, 2024
| @@ -979,6 +979,11 @@ expose_stan_functions <- function(function_env, global = FALSE, verbose = FALSE) | |||
| stop("Exporting standalone functions with external C++ is not available before CmdStan 2.32", | |||
| call. = FALSE) | |||
| } | |||
| if (!is.null(function_env$hpp_code) && | |||
| !any(grepl("[[stan::function]]", function_env$hpp_code, fixed = TRUE))) { | |||
There was a problem hiding this comment.
@andrjohns Is this an ok way to check whether there are any user defined functions?
andrjohns
approved these changes
Apr 23, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #956 +/- ##
==========================================
- Coverage 88.33% 87.28% -1.05%
==========================================
Files 12 13 +1
Lines 4553 4516 -37
==========================================
- Hits 4022 3942 -80
- Misses 531 574 +43 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #947
Submission Checklist
Summary
Continue with compilation if
compile_stanalone=TRUEbut no functions are found. Changes mysterious Rcpp error to an informative warning.Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Columbia University
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: